On 25.05.2009 13:35, [email protected] wrote:
> Author: libv
> New Revision: 546
>
> Biostar p4m80 board enable typo.
>
> Obvious typo due to inb/outb versus wbsio_ argument ordering confusion.
>
> Signed-off-by: Luc Verhaegen <[email protected]>
> Acked-by: Uwe Hermann <[email protected]>
>   

Thanks!

> Modified: trunk/board_enable.c
> ===================================================================
> --- trunk/board_enable.c      2009-05-23 00:56:49 UTC (rev 545)
> +++ trunk/board_enable.c      2009-05-25 11:35:25 UTC (rev 546)
> @@ -609,7 +609,7 @@
>       wbsio_mask(0x2e, 0x24, 0x04, 0x04);
>  
>       /* exit IT87xx conf mode */
>   

Shouldn't that comment refer to Winbond instead?

> -     wbsio_write(0x2, 0x2e, 0x2);
> +     wbsio_write(0x2e, 0x02, 0x02);
>  
>       return 0;
>  }
>   

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/


-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to