On 16.05.2009 01:30, Carl-Daniel Hailfinger wrote: > Use REMS instead of RES in the ICH SPI default opcode table. > > RES is Read Electronic Signature (1 Byte, identical for different chips) > REMS is Read Electronic Manufacturer Signature (2 Bytes, unique) > > Of the chips which don't support RDID, a sizable portion supports REMS > which gives us both a manufacturer ID and a device ID. This is clearly > superior to having only a device ID (the RES case) which has multiple > documented collisions. > > The best way forward would be to have the ICH SPI driver reprogram the > opcode menu on the fly if the opcode menu doesn't contain the requested > opcode and the opcode menu is not locked. Until that happens, this patch > improves detection accuracy by a factor of 256 for some chips. > > Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >
Ping? Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
