On 26.05.2009 15:58, Patrick Georgi wrote: > ron minnich schrieb: >> Is it necessary to nest the function to fix this problem? Are you sure >> no other function will ever need str_tx_byte? >> > As far as I can see, the global variable is only used for > communication between the two functions, of which one is a callback. > By nesting the function, the variable can be local. > > The only alternative I see is to rewrite that part entirely.
Dumb question: Can we simply copy the v3 code to v2 here? That would also give us nice benefits like printk buffering in the long term. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
