On Tue, May 26, 2009 at 07:20:12PM -0500, bari wrote: > Here's the VIA vx800 patch from OLPC. > > It's untested, but a good starting point for everyone. > > Signed-off-by: Bari Ari <[email protected]>
Thanks, committed in r4313. I agree we should get this merged first, then work from svn to improve the code. See below for a number of mostly small changes I did before the commit: > Index: src/northbridge/via/vx800/ddr2init/DramUtil.c > =================================================================== > --- src/northbridge/via/vx800/ddr2init/DramUtil.c (revision 0) > +++ src/northbridge/via/vx800/ddr2init/DramUtil.c (revision 0) > @@ -0,0 +1,247 @@ > +/* > + * This file is part of the coreboot project. > + * > + * Copyright (C) 2009 One Laptop per Child, Association, Inc. > + * Missing line: * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > + */ > Index: src/northbridge/via/vx800/ddr2init/vx800/DevInit.c > =================================================================== > --- src/northbridge/via/vx800/ddr2init/vx800/DevInit.c (revision 0) > +++ src/northbridge/via/vx800/ddr2init/vx800/DevInit.c (revision 0) > @@ -0,0 +1,1318 @@ > +/* > + * This file is part of the coreboot project. > + * > + * Copyright (C) 2009 One Laptop per Child, Association, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License Missing full stop. > Index: src/northbridge/via/vx800/romstrap.inc > =================================================================== > --- src/northbridge/via/vx800/romstrap.inc (revision 0) > +++ src/northbridge/via/vx800/romstrap.inc (revision 0) > @@ -0,0 +1,52 @@ > +/* > + * This file is part of the coreboot project. > + * > + * Copyright (C) 2004 Tyan Computer > + * (Written by Yinghai Lu <[email protected]> for Tyan Computer) > + * Copyright (C) 2007 Rudolf Marek <[email protected]> > + * Copyright (C) 2009 One Laptop per Child, Association, Inc. > + * > + * One useless newline. > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License. > Index: src/northbridge/via/vx800/DrivingClkPhaseData.h > =================================================================== > --- src/northbridge/via/vx800/DrivingClkPhaseData.h (revision 0) > +++ src/northbridge/via/vx800/DrivingClkPhaseData.h (revision 0) > @@ -0,0 +1,69 @@ > +/* > + * This file is part of the coreboot project. > + * > + * Copyright (C) 2009 One Laptop per Child, Association, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License Missing full stop. > Index: src/northbridge/via/vx800/vx800_early_serial.c > =================================================================== > --- src/northbridge/via/vx800/vx800_early_serial.c (revision 0) > +++ src/northbridge/via/vx800/vx800_early_serial.c (revision 0) Missing GPL header in this file. I took the freedom to add the usual "(C) 2009 OLPC, GPL2" header, please complain if the license should be different for this file. > Index: src/northbridge/via/vx800/Config.lb > =================================================================== > --- src/northbridge/via/vx800/Config.lb (revision 0) > +++ src/northbridge/via/vx800/Config.lb (revision 0) > @@ -0,0 +1,25 @@ > +## > +## This file is part of the coreboot project. > +## > +## Copyright (C) 2009 One Laptop per Child, Association, Inc. > +## > +## This program is free software; you can redistribute it and/or modify > +## it under the terms of the GNU General Public License as published by > +## the Free Software Foundation; version 2 of the License Missing full stop. My suggestion is to semi-automatically convert all the code to our coding guidelines using indent plus manual fixups (do _not_ blindly run indent and commit, this will surely not work properly; the indent output will definately need some fixing). I think I can do an indent-run today or so, but other people should then hold off of additional changes before the indenting has been committed, otherwise patches will need lost of ugly rebasing. Thanks, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
