See patch. I cannot think of any situation where we would not want to verify, and verifying always will help many users to properly detect misflashes.
The patch is not tested on hardware (yet), might need a bit of tweaking. If this goes in the -v option will stay for (a) backwards compatibility (b) manual verifying via 'flashrom -v file.bin' (vs. -wv directly) Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Always verify write and erase operations, there are no situations where we would _not_ want to verify, I think. There have been many reports where users assumed a write had worked, but they didn't use -wv (only -w) and thus couldn't be sure. Signed-off-by: Uwe Hermann <[email protected]> Index: flashrom.c =================================================================== --- flashrom.c (Revision 553) +++ flashrom.c (Arbeitskopie) @@ -687,6 +687,10 @@ exit(1); } + /* Always verify write and erase operations. */ + if (write_it || erase_it) + verify_it = 1; + size = flash->total_size * 1024; buf = (uint8_t *) calloc(size, sizeof(char));
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
