Hi all, log: Fix warning in satasii.c. This fix is simple as in i think it doesnt change the code logic at all and doesnt add a level of parentheses (ugly), but i can't test as i dont have the necessary hardware.
Signed-off-by: Urja Rannikko <[email protected]> I got this warning (as error) compiling flashrom with gcc 4.4.0: cc -Os -Wall -Werror -c -o satasii.o satasii.c cc1: warnings being treated as errors satasii.c: In function ‘satasii_init’: satasii.c:67: error: suggest parentheses around operand of ‘!’ or change ‘&’ to ‘&&’ or ‘!’ to ‘~’ Patch also inlined: Index: satasii.c =================================================================== --- satasii.c (revision 557) +++ satasii.c (working copy) @@ -64,7 +64,7 @@ sii_bar = physmap("SATA SIL registers", addr, 0x100) + reg_offset; /* Check if ROM cycle are OK. */ - if ((id != 0x0680) && (!(mmio_readl(sii_bar)) & (1 << 26))) + if ((id != 0x0680) && ((!mmio_readl(sii_bar)) & (1 << 26))) printf("Warning: Flash seems unconnected.\n"); return 0; -- urjaman
satasii_warning.patch
Description: Binary data
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
