On Fri, May 22, 2009 at 03:54:43AM +0300, Elia Yehuda wrote: > > On Sun, 10 May 2009 15:21:52 +0300, Elia Yehuda <[email protected]> wrote: > > > This patch enables the onboard VGA found on 82810 boards and fixes the > > > memory procedures to support different kinds of DIMMs. also, support for > > > 82810e board had been added. The only drawback from this patch is the > > > HAVE_HIGH_TABLES being disabled since it disables (for unknown reason) > > > the onboard VGA. > > > > > > Signed-off-by: Elia Yehuda <[email protected]> > > > > Elia, any progress on the high tables stuff yet? It would be real shame to > > see this great code goto the way side. Maybe you could split the patch in > > two and we can get all the non high tables stuff commited to svn? > > > im still waiting for Uwe to try the patch - he has some issues with his > hardware so we > need to have patience.
Yeah, sorry for the long delay. I had hardware issues, which I fixed by replacing some dead capacitors on my i810 board. I have successfully tested the (slightly modified for cosmetics) BUFF_SC parts of the patch, which works fine and is thus committed as r4338 (thanks!) > If this won't work out, then i'll do my best and > trace the high-tables > issue myself and update the list as for my findings. > > as for splitting the patch - can be done, but i suggest we wait a bit and > give Uwe a chance In general I recommend to split patches into independent functional units indeed, that makes testing and reviewing a lot easier. Haven't had much luck with the HIGH_TABLES stuff yet, need to look into it some more, will post the remainders of the patch (without the now-committed BUFF_SC parts) later and/or check what's going on with HIGH_TABLES... Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
