On 05.06.2009 23:06, Carl-Daniel Hailfinger wrote:
> Sorry. It seems I overlooked these during my abuild run. Basically, all
> non-revF K8 are broken because printk_raminit is not defined.
>   

Fix non-revF K8 ram init compilation which was broken in r4341.

abuild tested on affected targets.

Signed-off-by: Carl-Daniel Hailfinger <[email protected]>

Index: 
LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c
===================================================================
--- 
LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c    
    (Revision 4341)
+++ 
LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c    
    (Arbeitskopie)
@@ -19,6 +19,14 @@
 #define QRANK_DIMM_SUPPORT 0
 #endif
 
+#define RAM_TIMING_DEBUG 0
+
+#if RAM_TIMING_DEBUG == 1
+#define printk_raminit printk_debug
+#else
+#define printk_raminit(fmt, arg...)
+#endif
+
 #if defined (__GNUC__)
 static void hard_reset(void);
 #endif
@@ -2106,7 +2114,7 @@
        return;
  hw_spd_err:
        /* Unrecoverable error reading SPD data */
-       print_err("SPD error - reset\n");
+       printk_err("SPD error - reset\n");
        hard_reset();
        return;
 }


-- 
http://www.hailfinger.org/

Index: 
LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c
===================================================================
--- 
LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c    
    (Revision 4341)
+++ 
LinuxBIOSv2-k8_raminit_debugmessages_fix/src/northbridge/amd/amdk8/raminit.c    
    (Arbeitskopie)
@@ -19,6 +19,14 @@
 #define QRANK_DIMM_SUPPORT 0
 #endif
 
+#define RAM_TIMING_DEBUG 0
+
+#if RAM_TIMING_DEBUG == 1
+#define printk_raminit printk_debug
+#else
+#define printk_raminit(fmt, arg...)
+#endif
+
 #if defined (__GNUC__)
 static void hard_reset(void);
 #endif
@@ -2106,7 +2114,7 @@
        return;
  hw_spd_err:
        /* Unrecoverable error reading SPD data */
-       print_err("SPD error - reset\n");
+       printk_err("SPD error - reset\n");
        hard_reset();
        return;
 }
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to