See attached. Thanks, Ward.
-- Ward Vandewege <[email protected]> Free Software Foundation - Senior Systems Administrator
Make sure the address variable is initialized to zero - it is only set when a [base address] parameter is supplied on the command line... This patch fixes random segfaults when using 'cbfstool add'. Signed-off-by: Ward Vandewege <[email protected]> Index: util/cbfstool/add.c =================================================================== --- util/cbfstool/add.c (revision 4362) +++ util/cbfstool/add.c (working copy) @@ -238,7 +238,7 @@ int add_handler(struct rom *rom, int argc, char **argv) { unsigned int type = CBFS_COMPONENT_NULL; - unsigned long address; + unsigned long address = 0; if ((argc < 3) || (argc > 4)) { add_usage();
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
