On 24.06.2009 00:00, Uwe Hermann wrote: > On Mon, Jun 22, 2009 at 11:57:03AM +0200, Carl-Daniel Hailfinger wrote: > >> Check result of all SPI erase functions. >> Since block erase functions do not know the block length (it's not >> specified in any standard), block erase functions now get an additional >> parameter blocklen. This enables flashrom to verify the erase result for >> block erase functions at correct boundaries. >> >> Unchecked erase is bad and can lead to problems nobody can understand. >> >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> > > Acked-by: Uwe Hermann <[email protected]> > > Tested OK on an sb600 board. >
Thanks, committed in r. >> Index: flashrom-spi_verify_erase/spi.c >> =================================================================== >> - * Copyright (C) 2007, 2008 Carl-Daniel Hailfinger >> + * Copyright (C) 2007, 2008, 2009 Carl-Daniel Hailfinger >> > > Maybe 2007-2009 for brevity and shorter lines (on the long term). > I think I once read a comment which said that year ranges have no legal significance, they are like (C) convenient hints without meaning. Since copyright law is a strange beast and I'm not a lawyer, I prefer to be cautious. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
