On Fri, Jul 10, 2009 at 3:56 PM, Urja Rannikko<[email protected]> wrote: > + printf_debug("%s: addr=0x%lx len=%lu\n", __func__, addr, (unsigned > long)len);
I'm almost certain that it'd be better to user %z in the printf string here instead of casting to unsigned long and using %lu in the printf sting. Also, I think it'd be nice to see a major reduction in the number of casts used in the code if possible. Casts have a real potential to introduce really subtle errors into the code. Thanks, wt -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
