Carl-Daniel Hailfinger schrieb: > Hi Patrick, > > On 05.08.2009 13:04, Patrick Georgi wrote: > >> as preparation for the kconfig merge, here are some changes from the >> kconfig tree that are unrelated to kconfig itself. >> >> 20090805-1-ttys0-rename >> Takes care of the different CONFIG_* names of the variable containing >> the serial I/O port >> >> > > There should only be one config variable for this. Wouldn't a global > search/replace be able to standardize on either CONFIG_TTYS0_BASE or > CONFIG_SERIAL_IOBASE? > I _think_ the CONFIG_SERIAL_IOBASE was introduced in the kconfig stuff to be more similar to v3. Once we decide on one or the other, I can replace the respective occurrences. I don't care much and would go for CONFIG_TTYS0_BASE as that is what exists in the codebase. I'll prepare a patch.
>> 20090805-2-config-prefixes >> Some more CONFIG_* prefixes that were missing >> >> > > I don't particularly like the CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL > #define, but since that code already looks like this and you only added > a prefix, it is > Acked-by: Carl-Daniel Hailfinger <[email protected]> > Maybe we can get rid of this eventually, but for now this gets in. One battle at a time. r4497 >> 20090805-3-empty-files >> These changes exist mostly to make diff happy, which ignores empty files >> (or rather: Make Patrick happy when he's using diff). Maybe the right >> way would be to delete those files. >> >> > > If deleting these files doesn't break abuild, please delete them. For > the deletion, you can use my ack. > It will require some more work, as these empty files are still included at some places I think. I'll keep this open for discussion. Thanks, Patrick -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
