On Tue, Aug 25, 2009 at 11:37 AM, Patrick Georgi<[email protected]> wrote: > Am Dienstag, den 25.08.2009, 11:10 -0600 schrieb Myles Watson: >> On Tue, Aug 25, 2009 at 10:56 AM, Patrick Georgi<[email protected]> >> wrote: >> > In the mainboard selection, the selected mainboard is printed twice in >> > certain cases, this patch eliminates the second mention. >> > >> > This change might have unintended side-effects, but seems to work okay >> I'd rather fix the offending boards. Isn't it board-specific? Maybe >> I haven't seen all the cases. > No, it's specific to the Kconfig source layout: > > choice > config { THE BOARDS } > config { THE BOARDS' DEPENDENCIES } > endchoice > > To fix that, we'd have to do > choice > config { THE BOARDS } > endchoice > config { THE BOARDS' DEPENDENCIES } > > which doesn't work with the source statement
How about this fix? Signed-off-by: Myles Watson <[email protected]> Thanks, Myles
Index: src/mainboard/asus/Kconfig =================================================================== --- src/mainboard/asus/Kconfig (revision 4582) +++ src/mainboard/asus/Kconfig (working copy) @@ -21,8 +21,22 @@ choice prompt "Mainboard model" depends on VENDOR_ASUS - -source "src/mainboard/asus/p2b-f/Kconfig" +config BOARD_ASUS_P2B_F + bool "P2B-F" + select ARCH_X86 + select CPU_INTEL_SLOT_2 + select NORTHBRIDGE_INTEL_I440BX + select SOUTHBRIDGE_INTEL_I82371EB + select SUPERIO_WINBOND_W83977TF + select HAVE_PIRQ_TABLE + select UDELAY_IO + select PCI_ROM_RUN + select CONSOLE_VGA + help + ASUS P2B-F mainboard. + endchoice +source "src/mainboard/asus/p2b-f/Kconfig" + Index: src/mainboard/asus/p2b-f/Kconfig =================================================================== --- src/mainboard/asus/p2b-f/Kconfig (revision 4582) +++ src/mainboard/asus/p2b-f/Kconfig (working copy) @@ -18,20 +18,6 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -config BOARD_ASUS_P2B_F - bool "P2B-F" - select ARCH_X86 - select CPU_INTEL_SLOT_2 - select NORTHBRIDGE_INTEL_I440BX - select SOUTHBRIDGE_INTEL_I82371EB - select SUPERIO_WINBOND_W83977TF - select HAVE_PIRQ_TABLE - select UDELAY_IO - select PCI_ROM_RUN - select CONSOLE_VGA - help - ASUS P2B-F mainboard. - config MAINBOARD_DIR string default asus/p2b-f
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
