Hi,

With this patch, the resource allocator doesn't complain about 0-sized
fixed resources that aren't actually fixed. No harm done, except minor
confusion when warnings about fixed resources appear when there are no
fixed resources.


Signed-off-by: Patrick Georgi <[email protected]>


Patrick
Index: src/devices/device.c
===================================================================
--- src/devices/device.c	(Revision 4605)
+++ src/devices/device.c	(Arbeitskopie)
@@ -556,14 +556,14 @@
 	/* Constrain limits based on the fixed resources of this device. */
 	for (i = 0; i < dev->resources; i++) {
 		res = &dev->resource[i];
+		if (!(res->flags & IORESOURCE_FIXED))
+			continue;
 		if (!res->size) {
 			/* It makes no sense to have 0-sized, fixed resources.*/
 			printk_err("skipping %...@%lx fixed resource, size=0!\n",
 				   dev_path(dev), res->index);
 			continue;
 		}
-		if (!(res->flags & IORESOURCE_FIXED))
-			continue;
 
 		/* PREFETCH, MEM, or I/O - skip any others. */
 		if ((res->flags & MEM_MASK) == PREF_TYPE)
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to