>
> Great work!
>
> Kconfig_bools.diff defines LOGICAL_CPUS as bool, shouldn't it be left as
> int instead?


It is used as either true or false.  The way to tell how many logical CPUs
there might be is dividing CONFIG_MAX_CPUS and CONFIG_MAX_PHYSICAL_CPUS.

from  src/northbridge/amd/amdk8/.svn/text-base/northbridge.c.svn-base:
    disable_siblings = !CONFIG_LOGICAL_CPUS;

Thanks for the review,
Myles
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to