On 27.09.2009 20:49, Stefan Reinauer wrote:
> Simplify coreboot PCI handling
>
> This patch drops the conf1/conf2 autodetection and replaces it by
> (usually northbridge specific) hardcodes.
>
> This patch also adds pci_domain_init() which needs to be called by
> mainboard enable_dev() functions in order to be able to use the pci
> config space functions. This allows to drop i386 specific code from
> generic files again...
>
> There is an even better approach to the PCI config space access in mainboard
> specific init files problem, but that should go into another patch:
>
> static void init(struct device *dev)
> {
> // Do the stuff here!
> }
>
> static void enable_dev(struct device *dev)
> {
> // Install an init function for this mainboard device
> dev->ops->init = init;
> }
>
> struct chip_operations mainboard_ops = {
> .enable_dev = enable_dev,
> };
>
> Signed-off-by: Stefan Reinauer <[email protected]>
>
I really like this patch. There are one or two things I don't understand
yet, but I hope stuff will become clearer tomorrow after testing. Will
ack after testing.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
