On 01.10.2009 01:27, ron minnich wrote: > On Wed, Sep 30, 2009 at 4:16 PM, Carl-Daniel Hailfinger > <[email protected]> wrote: > >> Could we simply reuse arch/x86/stage1.c from v3 and run a search+replace >> lar->cbfs on that file? As a nice side benefit, we get global variables >> and similar stuff. >> > > I've looked into doing just that. It's not as simple as it sounds. >
I'm surprised. My stage1 SMP patch was never merged IIRC, so stack trashing is expected on any non-UP v3 boot. But other than that, v3 stage1 code worked pretty well. The ELFboot code in there should be dropped (was default off anyway) and then we have a pretty readable startup. > I'd rather not open that can of worms just yet. > If you're talking about doing too many things at once, I fully agree. Once the tree is CBFS-only and once Kconfig works for all actively developed boards, we will have a mostly stable tree again and it would be cool to look at importing stage1 (and possibly stage0) from v3. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
