On Wed, Oct 7, 2009 at 1:32 PM, Uwe Hermann <[email protected]> wrote: > See patch. Index: src/mainboard/intel/xe7501devkit/irq_tables.c =================================================================== --- src/mainboard/intel/xe7501devkit/irq_tables.c (Revision 4738) +++ src/mainboard/intel/xe7501devkit/irq_tables.c (Arbeitskopie) @@ -20,7 +20,7 @@ const struct irq_routing_table intel_irq_routing_table = { PIRQ_SIGNATURE, PIRQ_VERSION, - 32 + 12*sizeof(struct irq_info), // Size of this struct in bytes + 32 + 16 * CONFIG_IRQ_SLOT_COUNT, // Size of this struct in bytes
I like the sizeof. It removes one magic number. Besides that everything looks good. Acked-by: Myles Watson <[email protected]> Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
