On Thu, Oct 8, 2009 at 9:31 AM, Peter Stuge <[email protected]> wrote: > ron minnich wrote: >> failover.inc MUST come after enable_sse or your CPU will hang. > > Can you say why?
yes. if you compile failover.c with romcc options that include sse, then you'll see code like this in failover.inc: mov eax, %xmm0 This will hang if you have not first enabled sse. Verified yesterday on the dell s1850. > > Does it hang in the SSE code or in the failover code? It will hang in failover code, if that code was compiled with sse. > > Does this mean that failover requires SSE in order to work? no, but if it uses sse, it will hang. > Acked-by: Peter Stuge <[email protected]> There's still one last bit of cleanup if this patch works: the makefile options for romcc need to depend on the cpu type. But one thing at a time. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
