On Thu, Oct 08, 2009 at 06:51:23PM +0200, Peter Stuge wrote: > [email protected] wrote: > > +++ trunk/coreboot-v2/src/cpu/amd/model_lx/Kconfig 2009-10-08 14:31:56 UTC > > (rev 4743) > > @@ -0,0 +1,4 @@ > > +config CPU_AMD_LX > > + bool > > + default n > > + > > It would be nice to have GEODE in this name.
I think the current practice is to match the directory names in CONFIG_* variable names. But we _should_ use the full correct names in strings (e.g. board names appearing in menuconfig). > > +++ trunk/coreboot-v2/src/cpu/amd/sc520/Kconfig 2009-10-08 14:31:56 UTC > > (rev 4743) > > @@ -0,0 +1,4 @@ > > +config CPU_AMD_SC520 > > + bool > > + default n > > + > > Maybe ELAN here? See above. > > +config BOARD_IEI_PCISA_LX_800_R10 > > + bool "PCISA lx-800 r10" > > These new board names seem to be mostly lowercase, which isn't really > right. I'll fix the ones I know about. Yeah, multiple are wrong. I'll go over all of them once the kconfig transition is completed, unless you beat me to it. > This looks similar if not identical among very many boards. Can they > be folded together? Sorry if I am nagging about this. They will, once all boards have been converted to kconfig. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
