On Fri, Oct 9, 2009 at 1:19 PM, Peter Stuge <[email protected]> wrote: > [email protected] wrote: >> +++ trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c 2009-10-09 20:07:48 >> UTC (rev 4755) > .. >> @@ -278,12 +259,17 @@ >> w = inw(0x866); >> outw(w|2, 0x866); >> >> +#if 0 >> + /*seriaice shows >> + dell does this so leave it here so I don't forget >> + */ >> /* SMBUS */ >> pci_write_config16(PCI_DEV(0, 0x1f, 3), 0x20, 0x08c0); >> >> /* unknown */ >> b = inb(0x8c2); >> outb(0xdf, 0x8c2); >> +#endif > > Maybe this should be deleted until it's known to be neccessary?
I actually left it in there so the next time someone runs serial ice on the factory bios, and sees this sequence, they don't panic and put it in. It's not needed. I'm leaving it there so we will be sure we all know it's not needed ... I will comment it better. ron -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
