On Fri, Oct 16, 2009 at 8:48 AM, ron minnich <[email protected]> wrote:
> On Fri, Oct 16, 2009 at 7:41 AM, Myles Watson <[email protected]> wrote: > > > The problem with this style is that it doesn't support conditional > > compilation. In this case it doesn't matter, but if you wanted to put > in: > > > > if(CONFIG_HAVE_MP_TABLE) { > > use_some_MP_defines(); > > } > > > > It would break, wouldn't it? Since CONFIG_ variables are used to control > > what gets included in the image, I think we should stick with #if. > > Why would that break? > Before it gets optimized out it will look for the definition of the function which wasn't compiled in and whose headers weren't included. Won't it break? I could try it with some of the k8 raminit code that has conditional includes all over the place. Thanks, Myles
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
