On Fri, Oct 16, 2009 at 10:12 AM, Peter Stuge <[email protected]> wrote:

> Myles Watson wrote:
> > There was only one place where I had to do (RAMBASE >> 10)!
>

> Maybe change that one to / 1024 instead?
>
Do you think it's clearer to use /1024?  I just meant it was surprising to
multiply the value by 1024 and only have to put it back once.

In a few places CONFIG_RAMTOP is used without (), but none of them
> looked bad. Maybe also search for ",CONFIG_RAMTOP" and add a space
> there.
>
Fixed.

Thanks,
Myles
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to