Myles Watson wrote: > +config GENERATE_ACPI_TABLES > bool > + default y if HAVE_ACPI_TABLES > + default n
Can it be simply: default HAVE_ACPI_TABLES ? > +++ svn/src/northbridge/amd/amdfam10/Kconfig > @@ -21,11 +21,35 @@ config NORTHBRIDGE_AMD_AMDFAM10 > bool > select HAVE_HIGH_TABLES > select HYPERTRANSPORT_PLUGIN_SUPPORT > - select HT3_SUPPORT > > config AGP_APERTURE_SIZE > hex > default 0x4000000 > depends on NORTHBRIDGE_AMD_AMDFAM10 > > +config HT3_SUPPORT > + bool > + default y > + depends on NORTHBRIDGE_AMD_AMDFAM10 Is this good? I find having single line selects instead of repeating the horribly long NB option name over and over very appealing but I don't know enough about Kconfig to say if it makes a difference? Essentially this is a doubly linked list where both links must be explicitly described by Kconfig file authors, and I would so prefer if only one link needed to be described explicitly. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
