Carl-Daniel Hailfinger wrote: > On 24.10.2009 03:12, Stefan Reinauer wrote: > >> re-order console output functions, add proper prototypes, >> drop claim that our files were blatantly copied, because they have been >> rewritten a very long time ago. >> >> Signed-off-by: Stefan Reinauer <[email protected]> >> >> > > I don't have a v2 tree handy right now, so I can't diff the result of > your patch with my v3 tree. How are your new code and the v3 code > related? Is this a rewrite of the existing v2 code or really just a > reodering? (diff generated a patch which is not exactly readable, but > that's not your fault.) > It's just moving functions around. Oops, and the changelog missed this: it fixes a locking issue in sprintf.
> Looks good, though. > > If you drop the unrelated ACPI hunk in src/config/Options.lb, this is > Acked-by: Carl-Daniel Hailfinger <[email protected]> > This sneaked in accidentally...ACPI hunk dropped. Thanks, r4837 -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot

