src/cpu/x86/smm/Makefile.inc:33: warning: overriding commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm.o' src/cpu/x86/smm/Makefile.inc:33: warning: ignoring old commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm.o' src/cpu/x86/smm/Makefile.inc:36: warning: overriding commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm' src/cpu/x86/smm/Makefile.inc:36: warning: ignoring old commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm' src/cpu/x86/smm/Makefile.inc:41: warning: overriding commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm_bin.c' src/cpu/x86/smm/Makefile.inc:41: warning: ignoring old commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm_bin.c'
my...@orangutan:svn$ grep -Ir subdirs.*smm src/ | grep -v svn src/cpu/x86/Makefile.inc:subdirs-y += smm src/cpu/via/model_c7/Makefile.inc:subdirs-y += ../../x86/smm src/cpu/via/model_c3/Makefile.inc:subdirs-y += ../../x86/smm src/cpu/intel/ep80579/Makefile.inc:subdirs-y += ../../x86/smm First it gets included with src/cpu/x86, then with every cpu model. Can we just remove those? subdirs-y += amd subdirs-y += intel subdirs-y += via subdirs-y += emulation subdirs-y += x86 This is a little strange, though. All the rest are brands. To be consistent, I think we should remove subdirs-y += x86 from src/cpu/Makefile.inc, and let every CPU include it. Patch attached. Signed-off-by: Myles Watson <[email protected]> I'd be equally happy with every CPU (since we only have x86), just doing subdir-y += ../../x86 so they didn't have to be repeated. Thanks, Myles
Index: svn/src/cpu/Makefile.inc =================================================================== --- svn.orig/src/cpu/Makefile.inc +++ svn/src/cpu/Makefile.inc @@ -2,4 +2,3 @@ subdirs-y += amd subdirs-y += intel subdirs-y += via subdirs-y += emulation -subdirs-y += x86 Index: svn/src/cpu/x86/Makefile.inc =================================================================== --- svn.orig/src/cpu/x86/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -subdirs-y += smm
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
