On Wed, Oct 28, 2009 at 10:28 AM, Myles Watson <[email protected]> wrote:

>
>
> On Wed, Oct 28, 2009 at 10:19 AM, Uwe Hermann <[email protected]> wrote:
>
>> See patch.
>>
> Thanks for finding the build I missed.
>
> I'd prefer having "(This may take a while)" on the next line so that it
> doesn't wrap.
>
> I prefer
> -    print '    SCONFIG     Output File:', os.path.basename(
> outputfilename)
>
> over custom splits and joins.
>
> +    print '    SCONFIG   ', join(outputfilename.split('/')[-5:], '/')
>
I can see the point to having part of the path there.  It can help us keep
things in the correct directories.  I keep finding places where we
accidentally put things in the top directory.

Acked-by: Myles Watson <[email protected]>

Thanks,
Myles

>
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to