[coreboot] [PATCH]More helpful error if cbfs header magic is 0xffffffff

[Patrick Georgi]

Hi,

attached patch hopefully helps track down issues related to late 
enable_rom calls.
If the CBFS header magic is 0xffffffff, chances are that this is because 
the lower parts of the ROM aren't mapped yet. Point to 
http://www.coreboot.org/Infrastructure_Projects#CBFS, which provides 
some description and a nice table (Thanks Uwe!) about the current status.


Signed-off-by: Patrick Georgi <patrick.geo...@coresystems.de>
Index: src/lib/cbfs.c
===================================================================
--- src/lib/cbfs.c      (revision 4930)
+++ src/lib/cbfs.c      (working copy)
@@ -66,6 +66,10 @@
        printk_spew("magic is %08x\n", ntohl(header->magic));
        if (ntohl(header->magic) != CBFS_HEADER_MAGIC) {
                printk_err("ERROR: No valid CBFS header found!\n");
+               if (header->magic == 0xffffffff) {
+                       printk_err("Maybe the ROM isn't entirely mapped yet?\n"
+                               "See (and report to) 
http://www.coreboot.org/Infrastructure_Projects#CBFS\n";);
+               }
                return NULL;
        }
 
-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot