On Tue, Dec 15, 2009 at 11:21 AM, ron minnich <[email protected]> wrote:
> On Tue, Dec 15, 2009 at 9:06 AM, Myles Watson <[email protected]> wrote: > > > >> yes I can confirm that the Kconfig build method work for me too. As > >> Rudolf said I had to disable VGA ROM as well otherwise it will came up > >> with a exception error. It's necessary to have "Serial port console > >> output" set to yes or it won't compile. > > > > I'm not sure it makes sense for Coreboot to have that option. It only > takes > > a few #if defined() statements to make it compile, but I'd rather see the > > option disappear. Users that want more speed can choose a different > console > > verbosity. > > > > Comments? > > > Assuming all machines now and forever will have serial console ... I > am pretty sure that's an unsafe assumption. > I guess I was looking at it more like this: All the boards that we support have serial ports. If we have a serial port it makes sense to enable it. The option to disable the serial port should disappear because it can be subsumed in the "I have a serial port (CONFIG_SUPERIO_*)" option. I can see your point, though. So, to fix the problem of Kconfig having options that break the build, you'd like to use #ifdefs, right? Thanks, Myles
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
