On Thu, 28 Jan 2010 10:13:40 -0800, ron minnich <[email protected]> wrote:
> On Thu, Jan 28, 2010 at 9:21 AM, Peter Stuge <[email protected]> wrote:
>
>> In general I'm inclined to Ack, but my only reservation is that some
>> of the calls to ram_check() might point to particularly strategic
>> addresses for some boards, which were only known to the person who
>> did the port. If so, it would be nice to keep that information
>> somewhere..
>
>
> Which is my point. Where else would you put it? And, if it changes for
> some reason, you've now got to fix it in a document which people may
> not catch up with. That's a problem-generator.
>
Sorry Uwe, I am going to have to agree with Ron here. The ram_check() only
really needs to be used when developing or troubleshooting raminit. For a
regular build it is not needed, and in my opinion just complicates kconfig.
--
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
