On 2/22/10 1:56 PM, Joseph Smith wrote:
> I use die in raminit for memory compatibility checks. If the memory is not
> compatible, there is no use moving on...so we die().
>
>
I agree... to some extent...
The file I posted does not change the explicit die() calls though but
only the implicit die() in the two macros ASSERT and BUG.
As for memory compatibility, I saw the same thing on i945 - it does not
support ECC RAM and some closed source BIOSes just die() in the case of
ECC memory detected. However, it is possible to use the memory in
non-ECC mode, so not using die() might still be worth thinking about in
such a case. Worst case ram init does not work and then coreboot die()s
automatically when it tries jumping to stage 2 in RAM. It should,
however, always print a big fat BIOS_ERR warning in that case.
Stefan
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2010 coresystems GmbH
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; version 2 of
* the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
* MA 02110-1301 USA
*/
#ifndef __ASSERT_H__
#define __ASSERT_H__
#if defined(__PRE_RAM__) && !CONFIG_USE_PRINTK_IN_CAR
/* ROMCC versions */
#define ASSERT(x) { \
if(!(x)) { \
print_emerg("ASSERTION FAILED: file '"); \
print_emerg(__FILE__); \
print_emerg("', line 0x"); \
print_debug_hex32(__LINE__); \
print_emerg("\r\n"); \
/* die(""); */ \
} \
}
#define BUG() { \
print_emerg("BUG ENCOUNTERED: SYSTEM HALTED at file '");\
print_emerg(__FILE__); \
print_emerg("', line 0x"); \
print_debug_hex32(__LINE__); \
print_emerg("\r\n"); \
/* die(""); */ \
}
#else
/* GCC and CAR versions */
#define ASSERT(x) { \
if (!(x)) { \
printk_emerg("ASSERTION FAILED: file '%s', " \
" line %d\n", __FILE__, __LINE__); \
/* die(""); */ \
} \
}
#define BUG() { \
printk_emerg("BUG ENCOUNTERED: SYSTEM HALTED at file '%s', " \
" line %d\n", __FILE__, __LINE__); \
/* die(""); */ \
}
#endif
#endif // __ASSERT_H__
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
