Am 25.02.2010 16:27, schrieb Uwe Hermann: >> Index: src/cpu/via/model_c3/Kconfig >> =================================================================== >> --- src/cpu/via/model_c3/Kconfig (revision 5158) >> +++ src/cpu/via/model_c3/Kconfig (working copy) >> @@ -1,3 +1,4 @@ >> config CPU_VIA_C3 >> bool >> select UDELAY_TSC >> + select MMX >> Index: src/cpu/via/model_c7/Kconfig >> =================================================================== >> --- src/cpu/via/model_c7/Kconfig (revision 5158) >> +++ src/cpu/via/model_c7/Kconfig (working copy) >> @@ -1,3 +1,4 @@ >> config CPU_VIA_C7 >> bool >> select UDELAY_TSC >> + select MMX > > Are we sure all CPUs have MMX and SSE options set correctly? Are some > missing? At least those that require it for enable_mmx.inc and the like are set correctly.
>> initobj-y += crt0.o >> # FIXME in $(top)/Makefile > > I guess the FIXME comment can also be removed? Or does it refer to some > other lines? If no, please fix it in all files, there are multiple ones > with that comment. Will do. In principle, initobj-y += crt0.o could be moved to src/arch/i386/Makefile.inc as well. Yes, I intend to make mainboard Makefile.inc's optional. >> # Use Intel Core (not Core 2) code for CAR init, any CPU might be used. >> -crt0s += $(src)/cpu/intel/model_6ex/cache_as_ram.inc > > This comment is now in the wrong place. Thanks for spotting that, will move it. >> +# who else could use this? >> +ifeq ($(CONFIG_BOARD_TYAN_S2735),y) >> +crt0s += $(src)/cpu/x86/car/cache_as_ram.inc >> +endif > > Hm, in theory hopefully more Intel boards which use romcc now. Or is the > CAR file not generic enough (i.e. specific to the S2735 or its > CPU/chipset?) I have no idea which CPU this applies to. There are also some Via C7 boards that could be migrated to CAR, but I don't have the hardware. Patrick -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
