Patrick Georgi wrote: > >> + /* sb600_lpc_port80(); */ > >> + sb600_pci_port80(); > > > > This is a recurring pattern with both sb600 and sb700. Is there a > > reason to duplicate that call in a comment or could the comment just > > be removed? > > This was a mechanical refactoring without looking in-depth at such > issues. (all that code existed before)
Nod, yeah, I noticed it was there before. > There might be ways to refactor such code, but that requires a more > global view. Fair enough. > >> --- src/mainboard/amd/mahogany/cache_as_ram_auto.c (revision 5256) > > Where did this code go? > > src/mainboard/amd/mahogany/romstage.c already exists and is nearly > identical, except for an additional bugfix. Brilliant. Acked-by: Peter Stuge <[email protected]> -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
