On Tue, 23 Mar 2010 12:20:14 +0100, Stefan Reinauer <[email protected]>
wrote:
> On 3/23/10 12:14 PM, Joseph Smith wrote:
>
>> Good question. It does two checks. First to see if HPET is enabled, and
>> second to verify the hpet base address bits match the input value
(hpet).
>> If either one of these are false it leaves with a err message, makes
sure
>> HPET is disabled and continues on. Maybe printk_err() is a bit harsh
here
>> because it doesn't actually die() if there is an error, but I wanted to
>> make sure it is _KNOWN_ in the bootlog if there was an issue enabling
> HPET.
>> Does that make sense?
>>
> I think it does, since we're enabling an undocumented feature here.
> printk_err is fine.. die() is more along the line of printk_emerg
>
The Linux Kernel also does this check. Of course I added the very hpet base
address bits, as an extra safety check.
See arch/x86/kernel/quirks.c of the Linux Kernel for more info.
--
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
