See patch

The error message is misleading, even for a SPEW, because
the slot is empty, it's NOT a bad ID (and the message is
more confusing than helpful even in SPEW)

Signed-off-by: Stefan Reinauer <[email protected]>

Index: src/devices/pci_device.c
===================================================================
--- src/devices/pci_device.c    (revision 5344)
+++ src/devices/pci_device.c    (working copy)
@@ -910,11 +910,11 @@
                dummy.path.pci.devfn = devfn;
                id = pci_read_config32(&dummy, PCI_VENDOR_ID);
                /* Have we found something?
-                * Some broken boards return 0 if a slot is empty.
+                * Some broken boards return 0 if a slot is empty, but
+                * the expected answer is 0xffffffff
                 */
                if ((id == 0xffffffff) || (id == 0x00000000) ||
                    (id == 0x0000ffff) || (id == 0xffff0000)) {
-                       printk(BIOS_SPEW, "%s, bad id 0x%x\n", 
dev_path(&dummy), id);
                        return NULL;
                }
                dev = alloc_dev(bus, &dummy.path);
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to