> -----Original Message----- > From: [email protected] [mailto:[email protected]] > On Behalf Of repository service > Sent: Tuesday, April 06, 2010 3:50 PM > To: [email protected] > Subject: [coreboot] [commit] r5359 - in trunk/src: . > cpu/amd/model_10xxxcpu/amd/model_fxx cpu/amd/model_lx > cpu/x86/mtrrinclude/cpu/x86 > mainboard/amd/mahogany_fam10mainboard/amd/serengeti_cheetah > mainboard/asus/a8n_... > > Author: stepan > Date: Tue Apr 6 21:50:21 2010 > New Revision: 5359 > URL: https://tracker.coreboot.org/trac/coreboot/changeset/5359 > > Log: > No warnings day, next round. Thanks.
> trunk/src/cpu/x86/mtrr/earlymtrr.c > trunk/src/include/cpu/x86/mtrr.h > Modified: trunk/src/cpu/x86/mtrr/earlymtrr.c > ========================================================================== > ==== > --- trunk/src/cpu/x86/mtrr/earlymtrr.c Tue Apr 6 21:49:31 2010 > (r5358) > +++ trunk/src/cpu/x86/mtrr/earlymtrr.c Tue Apr 6 21:50:21 2010 > (r5359) > @@ -4,37 +4,7 @@ > #include <cpu/x86/mtrr.h> > #include <cpu/x86/msr.h> > > -/* Validate CONFIG_XIP_ROM_SIZE and CONFIG_XIP_ROM_BASE */ > -#if defined(CONFIG_XIP_ROM_SIZE) && !defined(CONFIG_XIP_ROM_BASE) > -# error "CONFIG_XIP_ROM_SIZE without CONFIG_XIP_ROM_BASE" ... I'm surprised you wanted to move this. It made sense to me to check it when compiling CAR. > Modified: trunk/src/include/cpu/x86/mtrr.h > ========================================================================== > ==== > --- trunk/src/include/cpu/x86/mtrr.h Tue Apr 6 21:49:31 2010 > (r5358) > +++ trunk/src/include/cpu/x86/mtrr.h Tue Apr 6 21:50:21 2010 > (r5359) ... > +#if !defined(CONFIG_RAMTOP) > +# error "CONFIG_RAMTOP not defined" > +#endif Now that we have Kconfig, I think this check can disappear. Is there a way to un-define CONFIG_RAMTOP? Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
