On Thu, Apr 8, 2010 at 5:03 PM, Stefan Reinauer <[email protected]>wrote:
> On 4/8/10 7:07 PM, Myles Watson wrote: > > Here's one for all boards. > > Signed-off-by: Myles Watson <[email protected]> > > Acked-by: Stefan Reinauer <[email protected]> <[email protected]> > Rev. 5384 > > Index: svn/src/mainboard/amd/dbm690t/acpi_tables.c > =================================================================== > --- svn.orig/src/mainboard/amd/dbm690t/acpi_tables.c > +++ svn/src/mainboard/amd/dbm690t/acpi_tables.c > @@ -57,7 +57,7 @@ static void dump_mem(u32 start, u32 end) > } > #endif > > -extern const acpi_header_t AmlCode; > +extern const unsigned char AmlCode[]; > > > I don't think defining them const here gains us much, as they're not > defined const when they're created. > I thought that making them const here would make it so that you couldn't do: AmlCode[23] = 'c'; without a warning. Can we change that, maybe? Extra sed s/unsigned char AmlCode/const unsigned > char AmlCode/g on the iasl output maybe? > That would be fine with me. It might be more effort than it's worth. As long as we copy it before anything else, there shouldn't be any problems. Thanks, Myles
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
