On Tue, Apr 6, 2010 at 4:21 PM, Myles Watson <[email protected]> wrote:

> I'm seeing code reads to memset() in coreboot_ram interleaved with byte
> writes to somewhere high on the stack (_estack -0x1fC).  This is a k8.
>

It turns out init_processor_name() was being called with the cache
disabled.  It doesn't look like it needs to be.  Boot tested on my box.
This makes it more similar to model_10.

Signed-off-by: Myles Watson <[email protected]>

Thanks,
Myles
Index: svn/src/cpu/amd/model_fxx/model_fxx_init.c
===================================================================
--- svn.orig/src/cpu/amd/model_fxx/model_fxx_init.c
+++ svn/src/cpu/amd/model_fxx/model_fxx_init.c
@@ -515,11 +515,11 @@ static void model_fxx_init(device_t dev)
 	msr.lo |= (1 << 0);
 	wrmsr(HWCR_MSR, msr);
 
+	enable_cache();
+
 	/* Set the processor name string */
 	init_processor_name();
 
-	enable_cache();
-
 	/* Enable the local cpu apics */
 	setup_lapic();
 
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to