2010/4/12 Keith Hui <[email protected]> > > > > This patch adds preliminary and untested ACPI support to Intel > 440BX/82371EB > > (e.g. ASUS P2B and its variants/similar boards). > > It focuses on an/the ASUS P2B which comes with three ram slots, hence the > > change to src/northbridge/intel/i440bx/raminit.c. > > > > Some parts are based on code from other boards and need some work. > > It is also based on a patch [1] from Keith Hui: in the attached patch > parts > > of src/southbridge/intel/i82371eb/i82371.h are and > > src/southbridge/intel/i82371eb/i82371eb_smbus.c is (C) Keith Hui. > > > > Todo: > > - create PRT objects > > - finish/fix FADT > > - finish all other ACPI tables (RSDT, RSDP, DSDT etcetera) > > - PIRQ routing > > - standby/suspend > > - ? > > > > Not Signing-off-by at this point. > > > > Idwer > > > > > > > > [1] http://www.coreboot.org/pipermail/coreboot/2010-March/056996.html > > -------------- next part -------------- > > An HTML attachment was scrubbed... > > URL: < > http://www.coreboot.org/pipermail/coreboot/attachments/20100412/98d9915c/attachment.html > > > > -------------- next part -------------- > > A non-text attachment was scrubbed... > > Name: coreboot_r5408_asus_p2b_ram+keithhui-pm+acpi-wip.patch > > This thing has my name on it! LOL.Thanks. > > I'm going to try it now. > > I am also going to try this with the ACPI tables from the vendor BIOS. > > The reason ACPI doesn't quite work is because coreboot does not > initialize i82371eb (PIIX4E) function 3 which controls ACPI and power > management. I have submitted a patch for initial work on this; Uwe is > reviewing it ATM. > > Make sure you do NOT define SDRAMPWR_4DIMM in Kconfig for P2B. I'll > see what else I missed there in supporting boards with 3 and 4 DIMM > slots.
Is the three or four DIMM choice committed ? Because I don't see it in Kconfig: http://tracker.coreboot.org/trac/coreboot/browser/trunk/src/mainboard/asus/p2b/Kconfig > BTW are you able to fill all three DIMM slots and have all memory come > up properly? You, with a 3-DIMM P2B, are the test case we have been > looking for. > Yes and yes, all memory comes up fine. Serial output: http://coreboot.pastebin.com/rPcXPiJ6 line 392 > Cheers > Keith > Idwer
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
