see patch. Not sure if this area is cached, but I think it should be,
none the less.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [email protected] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
move stack location to RAMBASE + HIGH_MEMORY_SAVE
Signed-off-by: Stefan Reinauer <[email protected]>
Index: src/cpu/via/car/cache_as_ram.inc
===================================================================
--- src/cpu/via/car/cache_as_ram.inc (revision 5410)
+++ src/cpu/via/car/cache_as_ram.inc (working copy)
@@ -270,14 +270,16 @@
movl %ebp, %esi
- /* FIXME: These values might have to change for suspend-to-ram.
- * the 0x00400000 was chosen as this is a place in memory that
- * should exist in all contemporary configurations (ie. large
- * enough RAM), but doesn't collide with anything coreboot does.
- * Other than that, it's arbitrary.
+ /* For now: use CONFIG_RAMBASE + 1MB - 64K (counting downwards) as
stack. This
+ * makes sure that we stay completely within the 1M-64K of memory that
we
+ * preserve for suspend/resume.
*/
- movl $0x4000000, %esp
+#ifndef HIGH_MEMORY_SAVE
+#warning Need a central place for HIGH_MEMORY_SAVE
+#define HIGH_MEMORY_SAVE ( (1024 - 64) * 1024 )
+#endif
+ movl $(CONFIG_RAMBASE + HIGH_MEMORY_SAVE), %esp
movl %esp, %ebp
pushl %esi
call copy_and_run
Index: src/arch/i386/init/crt0_romcc_epilogue.inc
===================================================================
--- src/arch/i386/init/crt0_romcc_epilogue.inc (revision 5410)
+++ src/arch/i386/init/crt0_romcc_epilogue.inc (working copy)
@@ -14,8 +14,16 @@
movl %ebp, %esi
- /* FIXME: look for a proper place for the stack */
- movl $0x4000000, %esp
+ /* For now: use CONFIG_RAMBASE + 1MB - 64K (counting downwards) as
stack. This
+ * makes sure that we stay completely within the 1M-64K of memory that
we
+ * preserve for suspend/resume.
+ */
+
+#ifndef HIGH_MEMORY_SAVE
+#warning Need a central place for HIGH_MEMORY_SAVE
+#define HIGH_MEMORY_SAVE ( (1024 - 64) * 1024 )
+#endif
+ movl $(CONFIG_RAMBASE + HIGH_MEMORY_SAVE), %esp
movl %esp, %ebp
pushl %esi
call copy_and_run
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
