Patrick Georgi wrote: > > - move src/arch/i386/smp/ioapic.c to src/arch/i386/lib/ioapic.c (has > > nothing to do with SMP) > > - move src/arch/i386/smp/mpspec.c to src/arch/i386/boot/mpspec.c (where > > acpi, pirq and coreboot table generation lives) > > - modify src/arch/i386/boot/Makefile.inc, src/arch/i386/lib/Makefile.inc > > and src/arch/i386/smp/Makefile.inc accordingly > > - src/arch/i386/smp is now empty. drop it. > > - drop src/arch/i386/init/car.S (unused) > Nice! > > > Signed-off-by: Stefan Reinauer <[email protected]> > Acked-by: Patrick Georgi <[email protected]>
Acked-by: Peter Stuge <[email protected]> > > * move boot/acpi* boot/mp* boot/pir* to arch/i386/tables/ or > > * move boot/acpi* to arch/i386/acpi > I'd like the tables to be as unified as possible (esp. when they're auto > generated at some point). So the first proposal sounds more appropriate. > > > * move src/arch/i386/lib/walkcbfs.S to src/arch/i386/init (where > > bootblock_* is) > Maybe move all of that to src/arch/i386/bootblock? > > > and maybe even src/{cpu,arch}. > Hmm.. I consider src/cpu to be "CPU drivers", while src/arch is > "architecture specific infrastructure". Not sure if that distinction is > really useful. I agree with Patrick in all the above. :) //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
