On Tue, May 4, 2010 at 5:40 PM, Nathan Williams <[email protected]> wrote: > On 5/05/2010 12:15 AM, Stefan Reinauer wrote: >> On 5/4/10 10:07 AM, Nathan Williams wrote: >>> Signed-off-by: Nathan Williams <[email protected]> >>> >>> - device pci 1.0 on end >>> - device pci 1.1 on end >>> + device pci 1.0 on end # Northbridge >>> + device pci 1.1 on end # Graphics >>> + device pci 1.2 on end # AES >> What's the impact of that change? >> >> Stefan >> > > I don't think it makes any difference. I just added it for > completeness/documentation.
In general we try to only specify the devices that must be specified because they have special driver needs. It keeps the device trees cleaner. Things that can be probed for and initialized by the generic code are better left alone. Maybe a comment in the lx code would be a good way to document other functions. Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
