Op zondag 9 mei 2010 00:36:49 schreef u: > On 5/1/10 1:34 AM, Nils wrote: > > Hi Stefan, > > First of all thanks for the great improvements in Geode (GX2). > > > > On 4/30/10 7:50 PM, Stefan Reinauer wrote: > >> src/northbridge/amd/gx2/chipsetinit.c:271: warning: suggest > >> parentheses around '-' inside '<<' > > > > This would need help from someone with a GX2 (or willing to check out > > the data sheets ;-) > > > > I would be happy if i could be of any help with this, I have a GX2 board > > i can test on. > > Can you test the following two patches: > > Index: northbridge/amd/gx2/chipsetinit.c > =================================================================== > --- northbridge/amd/gx2/chipsetinit.c (revision 5532) > +++ northbridge/amd/gx2/chipsetinit.c (working copy) > @@ -268,7 +268,7 @@ > if ((msr.lo&0xff) == 0x11) > return; > > - totalmem = sizeram() << 20 - 1; > + totalmem = (sizeram() << 20) - 1; > totalmem >>= 12; > totalmem = ~totalmem; > totalmem &= 0xfffff; > > > and this one > > Index: northbridge/amd/gx2/chipsetinit.c > =================================================================== > --- northbridge/amd/gx2/chipsetinit.c (revision 5532) > +++ northbridge/amd/gx2/chipsetinit.c (working copy) > @@ -268,7 +268,7 @@ > if ((msr.lo&0xff) == 0x11) > return; > > - totalmem = sizeram() << 20 - 1; > + totalmem = sizeram() << (20 - 1); > totalmem >>= 12; > totalmem = ~totalmem; > totalmem &= 0xfffff; > > > and see if any of them causes a failure? > > It would seem the first patch is correct and the second is not, but i am > not sure. > > > I saw your discussion about the warning before and it inspired me to > > dedicate my spare free time to again update my working rev5446 patches to > > current trunk. > > But unfortunately i can`t get it to work anymore on rev5120 and some > > other rev`s i tried. > > (Linux errors out with: "hda: lost interrupt") > > I will send the details in a separate mail. > > We do need to make sure we know the exact revision that broke this. > > Stefan > Yes, i wil test that next time i find some time for hobby, now i`m of to bed. On what revision would you like me to test?
Nils. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
