On Fri, May 14, 2010 at 09:24:29PM +0200, Stefan Reinauer wrote:
> Index: superio/smsc/fdc37n972/fdc37n972.c
> ===================================================================
> --- superio/smsc/fdc37n972/fdc37n972.c (revision 0)
> +++ superio/smsc/fdc37n972/fdc37n972.c (revision 0)
> @@ -0,0 +1,74 @@
[...]
> +static void enable_dev(struct device *dev)
> +{
> + pnp_enable_devices(dev, &pnp_ops,
> + sizeof(pnp_dev_info)/sizeof(pnp_dev_info[0]), pnp_dev_info);
Use ARRAY_SIZE here, please.
> Index: superio/smsc/sio10n268/sio10n268.c
> ===================================================================
> --- superio/smsc/sio10n268/sio10n268.c (revision 0)
> +++ superio/smsc/sio10n268/sio10n268.c (revision 0)
> @@ -0,0 +1,74 @@
[...]
> +static void enable_dev(struct device *dev)
> +{
> + pnp_enable_devices(dev, &pnp_ops,
> + sizeof(pnp_dev_info)/sizeof(pnp_dev_info[0]), pnp_dev_info);
Ditto, ARRAY_SIZE please.
Other than that:
Acked-by: Uwe Hermann <[email protected]>
Uwe.
--
http://hermann-uwe.de | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
