repository service wrote: > +++ trunk/src/Kconfig Sun May 16 17:31:53 2010 (r5560) > @@ -100,6 +100,10 @@ > > endmenu > > +menu "Generic Drivers" > +source src/drivers/Kconfig > +endmenu
Maybe some things that are in southbridge/ but aren't really southbridges goes there as well? > +++ trunk/src/drivers/Kconfig Sun May 16 17:31:53 2010 (r5560) .. > +config DRIVERS_SIL > + bool "Silicon Image SIL3114" > + default n > + help > + It sets PCI class to IDE compatible native mode, allowing > + SeaBIOS, FILO etc... to boot from it. Maybe the config is better named something that indicates which controllers it applies to? > +++ trunk/src/drivers/sil/3114/Makefile.inc Sun May 16 17:31:53 2010 > (r5560) > @@ -0,0 +1 @@ > +driver-$(CONFIG_DRIVERS_SIL) += sil_sata.o I think it would be good to rearrange a little bit so that the driver is included by select CONFIG_something in mainboards with a config option that is not visible in make menuconfig, and to have a separate option, visible to the user, for actually swithing the mode of the controller. Or will noone ever want to not switch the mode? //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
