Author: myles
Date: Fri May 21 19:15:55 2010
New Revision: 5577
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5577

Log:
Get rid of this warning:
 
src/cpu/amd/model_10xxx/fidvid.c:758:
        warning: 'fid_max' may be used uninitialized in this function

Quoting Marc:

It [fid_max] should be initialized to 0. The !nb_cof_vid_update would mean that
the fidmax shouldn't change so the value isn't important, but 0 would be the
safest if there is another hole in the logic and CPUs are not matched.

Signed-off-by: Myles Watson <[email protected]>
Acked-by: Myles Watson <[email protected]>

Modified:
   trunk/src/cpu/amd/model_10xxx/fidvid.c

Modified: trunk/src/cpu/amd/model_10xxx/fidvid.c
==============================================================================
--- trunk/src/cpu/amd/model_10xxx/fidvid.c      Fri May 21 16:33:48 2010        
(r5576)
+++ trunk/src/cpu/amd/model_10xxx/fidvid.c      Fri May 21 19:15:55 2010        
(r5577)
@@ -755,7 +755,7 @@
        struct fidvid_st fv;
        device_t dev;
        u32 vid_max;
-       u32 fid_max;
+       u32 fid_max=0;
        u8 nb_cof_vid_update;
        u32 reg1fc;
        u8 pvimode;

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to