On 05/21/2010 03:17 PM, Stefan Reinauer wrote:
On 5/21/10 7:25 AM, Joseph Smith wrote:
This patch improves the i82830 MBI SMI Handler. It is now able to load
Intel vbios VBT and Flexaim modules. Build and boot tested.
Signed-off-by: Joseph Smith <[email protected]>
God catch...
However, please don't commit this... it breaks the implementation of
MBI, the code should stay completely module agnostic. There should be a
solution that works without adding an exception for every module supported
(plus, I think the rules are based on the length of the name, so any
module 203 and 204 with different names will break your assumptions.
Even the existing code is not "completely module agnostic". There are
little + _some_number_ through out the code to adjust the data structure
sizes.......
--
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
