On 6/4/10 6:36 PM, Myles Watson wrote:
> if (!(res->flags & IORESOURCE_FIXED))
> continue;
> ...
>
> /* Is it already outside the limits? */
> - if (((res->base + res->size -1) < lim->base) || (res->base >
> lim->limit))
> + if (((res->base + res->size -1) < lim->base) || (res->base >
> lim->limit)) {
> + printk(BIOS_ERR, "%s: Resources not available.\n",
> dev_path(dev));
> continue;
> + }
>
> This code only is executed for fixed resources. If they are outside
> of the limits it's a good thing. I don't think there should be an
> error message.
>
Why is that good? (can we add that explanation to the code as a comment?)
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
