Stefan Reinauer wrote: > Drop the USE_PRINTK_IN_CAR option. It's a bogus decision to make for any user > / > board porter: printk should always be available in CAR mode. > > Also drop CONFIG_USE_INIT, it's only been selected on one ASROCK board but > it's > not been used there. Very odd. > > There is one usage of CONFIG_USE_INIT which was always off in > src/cpu/intel/car/cache_as_ram.inc and we have to figure out what to do with > those few lines. > > Signed-off-by: Stefan Reinauer <[email protected]>
With a fix as described below it's Acked-by: Peter Stuge <[email protected]> > +++ src/mainboard/amd/serengeti_cheetah/ap_romstage.c (working copy) .. > @@ -65,11 +63,7 @@ > > id = get_node_core_id_x(); > > -#if CONFIG_USE_PRINTK_IN_CAR > printk(BIOS_DEBUG, "CODE IN CACHE ON NODE: %02x\n"); > -#else > - print_debug("CODE IN CACHE ON NODE:"); print_debug_hex8(id.nodeid); > print_debug("\n"); > -#endif The remaining printk() call was+is missing the id.nodeid parameter. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
