repository service wrote: > +++ trunk/src/mainboard/gigabyte/ma785gmt/romstage.c Tue Aug 17 13:08:31 > 2010 (r5713) .. > @@ -137,6 +132,7 @@ > sb700_lpc_init(); > > it8718f_enable_serial(0, CONFIG_TTYS0_BASE); > + it8718f_disable_reboot(); > uart_init(); > console_init(); > printk(BIOS_DEBUG, "\n");
I know this was from a different commit, but I think maybe this _disable_reboot function should be moved out from the southbridge code, since it is not really specific for the it8718f southbridge. It is critical to add new code in the most appropriate place. It can be difficult to find sometimes, and may require some more changes around the coreboot code. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
